cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...
Date Fri, 17 Mar 2017 15:23:55 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1582#discussion_r106675353
  
    --- Diff: api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java ---
    @@ -75,6 +75,7 @@
         @Parameter(name = ApiConstants.CS_URL,
                    type = CommandType.STRING,
                    description = "the API URL including port of the CloudStack Management
Server example: http://server.cloud.com:8080/client/api?")
    +    // leaving cloud.com reference above as it serves only as an example
    --- End diff --
    
    ok, in that perspect you have a point absolutely. The sentence would need to be rephrased,
then. It now spells "example: http://..."!
    Ive been going through the, code reviewing every occurrence of cloud.com,.... back in
june!!! just before leaving the project to do some paid work ;) (hope my boss is alright with
this remark)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message