cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...
Date Fri, 17 Mar 2017 15:04:17 GMT
Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1582#discussion_r106670299
  
    --- Diff: api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java ---
    @@ -75,6 +75,7 @@
         @Parameter(name = ApiConstants.CS_URL,
                    type = CommandType.STRING,
                    description = "the API URL including port of the CloudStack Management
Server example: http://server.cloud.com:8080/client/api?")
    +    // leaving cloud.com reference above as it serves only as an example
    --- End diff --
    
    I agree that it is out of the scope. I just wanted to ask about the idea of starting using
notations instead of real URLs as examples.
    
    To tell you the truth I have already seen so many time people not thinking while seeing
examples like this and using a copy/paste working mode that I try to avoid it sometimes, just
to force people to change the parameters.
    
    It is nothing that you need to change, I just so it, and I wanted to check your opinion
;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message