cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rajesh-battala <...@git.apache.org>
Subject [GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack
Date Fri, 17 Mar 2017 09:59:17 GMT
Github user rajesh-battala commented on the issue:

    https://github.com/apache/cloudstack/pull/1859
  
    Current commits are in the order of some milestones.
    As @nitin-maharan told if we squash them into one commit we loose
    contributions of induviduals.
    
    
    On Thu, Mar 16, 2017 at 7:09 PM, Rohit Yadav <notifications@github.com>
    wrote:
    
    > @nitin-maharana <https://github.com/nitin-maharana> it becomes easier to
    > triage changes when changes are confined to a limited number of commits
    > (ideally one per PR), please squash the commits based on the author (if not
    > to a single commit) if you don't agree. Ideally, you can also group/squash
    > commits based on the component/framework/architecture.
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/cloudstack/pull/1859#issuecomment-287059366>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/AA-EAqDvOOOnKfG81zO6sgQ9KmIN0W92ks5rmTufgaJpZM4LUre4>
    > .
    >
    
    
    
    -- 
    Thanks
    Rajesh Battala



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message