cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <>
Subject [GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...
Date Thu, 16 Mar 2017 00:12:34 GMT
Github user rafaelweingartner commented on a diff in the pull request:
    --- Diff: engine/schema/src/com/cloud/storage/dao/ ---
    @@ -77,4 +92,71 @@ public void deleteTags(long poolId) {
    +    @Override
    +    public List<StoragePoolTagVO> searchByIds(Long... stIds) {
    +        final int detailsBatchSize = getDetailsBatchSize();
    +        // query details by batches
    +        List<StoragePoolTagVO> uvList = new ArrayList<StoragePoolTagVO>();
    +        int curr_index = 0;
    +        if (stIds.length > detailsBatchSize) {
    --- End diff --
    No problem ;)
    It is awesome the changes you have done here. The code became cleaner, with good documentation
and on top of that, we now have unit tests to guarantee that the methods are workings as expected.
    Great job @nvazquez, well done!
    PS: Sorry if I have been too picky with the code changes.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message