cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From koushik-das <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...
Date Wed, 15 Mar 2017 11:46:07 GMT
Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1853#discussion_r106138864
  
    --- Diff: server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java ---
    @@ -312,6 +317,65 @@ public DedicatedResourceVO findByHostId(Long hostId) {
         }
     
         @Override
    +    public List<DedicatedResourceVO> listAvailableResources(Long accountId, Long...
domains) {
    --- End diff --
    
    Please rewrite this using the standard query builder (SearchBuilder) that is available
and used in the other methods in this class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message