cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nvazquez <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...
Date Tue, 14 Mar 2017 18:22:59 GMT
Github user nvazquez commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1994#discussion_r105989477
  
    --- Diff: engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
    @@ -77,4 +90,68 @@ public void deleteTags(long poolId) {
             txn.commit();
         }
     
    +    @Override
    +    public List<StoragePoolTagVO> searchByIds(Long... stIds) {
    +        final int detailsBatchSize = getDetailsBatchSize();
    +
    +        // query details by batches
    +        List<StoragePoolTagVO> uvList = new ArrayList<StoragePoolTagVO>();
    +        int curr_index = 0;
    +
    +        if (stIds.length > detailsBatchSize) {
    +            while ((curr_index + detailsBatchSize) <= stIds.length) {
    +                searchForStoragePoolIdsInternal(curr_index, detailsBatchSize, stIds,
uvList);
    +                curr_index += detailsBatchSize;
    +            }
    +        }
    +
    +        if (curr_index < stIds.length) {
    +            int batch_size = (stIds.length - curr_index);
    +            searchForStoragePoolIdsInternal(curr_index, batch_size, stIds, uvList);
    +        }
    +
    +        return uvList;
    +    }
    +
    +    /**
    +     * Search storage pools
    +     * @param currIndex current index
    +     * @param batchSize batch size
    +     * @param stIds storage tags array
    +     * @param uvList
    +     */
    +    protected void searchForStoragePoolIdsInternal(int currIndex, int batchSize, Long[]
stIds, List<StoragePoolTagVO> uvList) {
    --- End diff --
    
    Excellent improvement, I copied almost exactly as you wrote it :) I also added some description
on `uvList` parameter, which also renamed to `pools`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message