cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <>
Subject [GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack
Date Mon, 13 Mar 2017 20:31:33 GMT
Github user rafaelweingartner commented on the issue:
    @nitin-maharana I was looking at the PR.
    Do you need to split everything thing there in a different commit?
    I think that we still do not have a clear understanding when and how to separate things
in a commit; however, anything like 90+ commits in a PR seems exaggerated to me.
    I like the philosophy that for every commit we should be able to get the system, build
it and use it. This, for instance, would not happen here. Again, as I said, I think we do
not have a clear rule about that, but I would like others to check this situation as well.
    @DaanHoogland, @rhtyd, @swill any thoughts here?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message