cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshanaparti <...@git.apache.org>
Subject [GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...
Date Mon, 13 Mar 2017 17:32:13 GMT
Github user sureshanaparti commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/837#discussion_r105722036
  
    --- Diff: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
    @@ -1049,7 +1044,13 @@ public boolean executeUserRequest(final long hostId, final Event
event) throws A
                 }
                 return true;
             } else if (event == Event.ShutdownRequested) {
    -            return reconnect(hostId);
    +            //should throw a exception here as well.instead of eating this up.
    +           try {
    +               reconnect(hostId);
    +           } catch (CloudRuntimeException e) {
    --- End diff --
    
    @bvbharatk Is it possible to take the failure reason forward?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message