cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sadhugit <...@git.apache.org>
Subject [GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...
Date Sun, 12 Mar 2017 09:07:23 GMT
Github user sadhugit commented on the issue:

    https://github.com/apache/cloudstack/pull/1813
  
    What about global root disk controller setting ? 
    
    storage level setting overwrite the global level setting  and global level setting has
no impact  that is reason  the initial logic was(earlier  code only  addressed globe config
parameter  and later changed to storage level after review  comments)  and now it only check
for storage level setting which  make sense.
    
    in  case of vmware -  it only supports iscsi and full clone (nfs as primary won't support)
.Also if the primary storage is iscsi  and full clone is set as  false ,script will automatically
update the config parameter to True  and will continue the execution instead of failing/skipping
but if the setup itself has has un supported storage then not worth   to proceed further so
it will skip all the test cases.
    
    if strpool.type == "VMFS":
                            list_config_storage_response = list_configurations(
                                cls.api_client
                                , name=
                                "vmware.create.full.clone",storageid=strpool.id)
                            res = validateList(list_config_storage_response)
                            if res[2]== INVALID_INPUT:
                             raise Exception("Failed to  list configurations ")
                            if list_config_storage_response[0].value == "false":
                                Configurations.update(cls.api_client,
                                                      "vmware.create.full.clone",
                                                      value="true",storageid=strpool.id)
                                cls.updateclone = True
                                StoragePool.update(cls.api_client,id=strpool.id,tags="iscsi")
                                cls.storageID = strpool.id
                                cls.unsupportedStorageType = False


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message