cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request #669: Made the adding new keyboard language support ...
Date Tue, 07 Mar 2017 20:28:06 GMT
Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/669#discussion_r104769820
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
    @@ -0,0 +1,59 @@
    +/*
    + *   Licensed to the Apache Software Foundation (ASF) under one
    + *   or more contributor license agreements.  See the NOTICE file
    + *   distributed with this work for additional information
    + *   regarding copyright ownership.  The ASF licenses this file
    + *   to you under the Apache License, Version 2.0 (the
    + *   "License"); you may not use this file except in compliance
    + *   with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *   Unless required by applicable law or agreed to in writing,
    + *   software distributed under the License is distributed on an
    + *   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + *   KIND, either express or implied.  See the License for the
    + *   specific language governing permissions and limitations
    + *   under the License.
    + */
    +
    +package com.cloud.hypervisor.kvm.resource.wrapper;
    +
    +import com.cloud.agent.api.Answer;
    +import com.cloud.agent.api.CopyFileInVmAnswer;
    +import com.cloud.agent.api.CopyFileInVmCommand;
    +import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
    +import com.cloud.resource.CommandWrapper;
    +import com.cloud.resource.ResourceWrapper;
    +import com.cloud.utils.ssh.SshHelper;
    +import org.apache.commons.io.FileUtils;
    +import org.apache.commons.io.filefilter.TrueFileFilter;
    +import org.apache.log4j.Logger;
    +
    +import java.io.File;
    +
    +@ResourceWrapper(handles = CopyFileInVmCommand.class)
    +public class LibvirtCopyFileInVmCommandWrapper   extends CommandWrapper<CopyFileInVmCommand,
Answer, LibvirtComputingResource> {
    +
    +    private static final Logger s_logger = Logger.getLogger(LibvirtCopyFileInVmCommandWrapper.class);
    +
    +    @Override public Answer execute(CopyFileInVmCommand cmd, LibvirtComputingResource
libvirtComputingResource) {
    +        final File keyFile = new File("/root/.ssh/id_rsa.cloud");
    +        try {
    +            File file = new File(cmd.getSrc());
    --- End diff --
    
    @anshul1886 please reduce these duplicated lines.
    Lines 42-57 here are the same as lines 608 - 622 on the class HypervDirectConnectResource.java.
    I know you already said these are objects dealing with different hypervisors. However,
the point here is that the process is the same no matter the hypervisor; thus, it is interesting
to avoid such redundancy of code.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message