cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...
Date Mon, 06 Mar 2017 16:07:25 GMT
Github user rafaelweingartner commented on the issue:

    https://github.com/apache/cloudstack/pull/1278
  
    @anshul1886 sorry, but I still do not understand you.
    
    Your changes affect `NetworkHelperImpl.java` class. Do we agree on that?
    
    You changed lines 334 and 512. You changed the call `startVirtualRouter`; this method
is implemented in the same `NetworkHelperImpl.java` class. Before you change the call was
`startVirtualRouter(router, _accountMgr.getSystemUser(), _accountMgr.getSystemAccount(), routerDeploymentDefinition.getParams())`;
then, you altered the code to `startVirtualRouter(router, callerUser, caller, routerDeploymentDefinition.getParams())`.

    
    You changed the way the code is retrieving objects “user” and “account”; before
the user was retrieved as `_accountMgr.getSystemUser()`, now it is retrieved as `_accountMgr.getActiveUser(CallContext.current().getCallingUserId())`.
The account was obtained as `_accountMgr.getSystemAccount()` and now it is obtained as `CallContext.current().getCallingAccount()`.
    
    Can we agree on this?
    
    You are telling me to look at the Deployment planner. However, what I fail to understand
is the following.
    
    Looking at lines 334 and 512, the `user` and `account` are passed as parameters to `com.cloud.network.router.NetworkHelperImpl.startVirtualRouter(DomainRouterVO,
User, Account, Map<Param, Object>)`. This method is in the same ` NetworkHelperImpl`
class. The only thing the ` startVirtualRouter` method does with the mentioned objects is
to send them as parameters to ` com.cloud.network.router.NetworkHelperImpl.start(DomainRouterVO,
User, Account, Map<Param, Object>, DeploymentPlan)` at lines 349, 387, or 412. Then,
the method to ` com.cloud.network.router.NetworkHelperImpl.start(DomainRouterVO, User, Account,
Map<Param, Object>, DeploymentPlan)` does not use the ` User` and `Account` objects.
    
    Can we agree on that?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message