cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <>
Subject [GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...
Date Thu, 02 Mar 2017 10:14:48 GMT
Github user DaanHoogland commented on a diff in the pull request:
    --- Diff: api/src/org/apache/cloudstack/api/command/admin/ha/
    @@ -0,0 +1,114 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +package org.apache.cloudstack.api.command.admin.ha;
    +import org.apache.cloudstack.acl.RoleType;
    +import org.apache.cloudstack.api.APICommand;
    +import org.apache.cloudstack.api.ApiArgValidator;
    +import org.apache.cloudstack.api.ApiConstants;
    +import org.apache.cloudstack.api.ApiErrorCode;
    +import org.apache.cloudstack.api.BaseAsyncCmd;
    +import org.apache.cloudstack.api.BaseCmd;
    +import org.apache.cloudstack.api.Parameter;
    +import org.apache.cloudstack.api.ServerApiException;
    +import org.apache.cloudstack.api.response.ClusterResponse;
    +import org.apache.cloudstack.api.response.SuccessResponse;
    +import org.apache.cloudstack.context.CallContext;
    +import org.apache.cloudstack.ha.HAConfigManager;
    +import javax.inject.Inject;
    +@APICommand(name = DisableHAForClusterCmd.APINAME, description = "Disables HA cluster-wide",
    --- End diff --
    If we decide to implement some kind of mirroring service for entire zones or clusters
for high availability, these would then be disabled / enabled for a zone or cluster. In this
case the enabling is done per host in the zone/cluster. That's why i consider the longer name
I propose more appropriate. That said the shorter the name the better as long as it is unambiguous.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message