Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: syed <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1963-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1963-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...
Content-Type: text/plain
Message-Id: <20170223193352.C8C20DFDB1@git1-us-west.apache.org>
Date: Thu, 23 Feb 2017 19:33:52 +0000 (UTC)
archived-at: Thu, 23 Feb 2017 19:33:54 -0000

Github user syed commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1963#discussion_r102798055
  
    --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java ---
    @@ -711,6 +711,7 @@ private void handleCreateVolumeFromSnapshotBothOnStorageSystem(SnapshotInfo snap
             }
             catch (Exception ex) {
                 errMsg = ex.getMessage() != null ? ex.getMessage() : "Copy operation failed in 'StorageSystemDataMotionStrategy.handleCreateVolumeFromSnapshotBothOnStorageSystem'";
    +            copyCmdAnswer = new CopyCmdAnswer(errMsg);
    --- End diff --
    
    That would be great @mike-tutkowski. That makes sure that the snapshot goes back to a good state if the storage driver operation fails. I will close this request then.
    

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---