Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: borisstoyanov <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1949-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1949-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1949: Cruds2
Content-Type: text/plain
Message-Id: <20170217111356.A7BF5DFB0E@git1-us-west.apache.org>
Date: Fri, 17 Feb 2017 11:13:56 +0000 (UTC)
archived-at: Fri, 17 Feb 2017 11:13:58 -0000

Github user borisstoyanov commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1949#discussion_r101735942
  
    --- Diff: tools/marvin/marvin/config/test_data.py ---
    @@ -121,7 +121,7 @@
                 "name": "LargeInstance",
                 "displaytext": "LargeInstance",
                 "cpunumber": 1,
    -            "cpuspeed": 500,
    +            "cpuspeed": 1024,
    --- End diff --
    
    while appending to this list could be fairly non fragile to tests, editing existing entries can be extremely fragile to other tests that are using it. We need to be sure this does not brake any of the smoketests, since they are our main source of verifying PRs. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---