Return-Path: <dev-return-105192-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 2853C200C1B
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue, 14 Feb 2017 10:01:34 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 2705F160B5F; Tue, 14 Feb 2017 09:01:34 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 664BA160B52
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 14 Feb 2017 10:01:33 +0100 (CET)
Received: (qmail 90590 invoked by uid 500); 14 Feb 2017 09:01:32 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 90579 invoked by uid 99); 14 Feb 2017 09:01:32 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Feb 2017 09:01:32 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 123D8DFD73; Tue, 14 Feb 2017 09:01:32 +0000 (UTC)
From: jayapalu <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1885-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1885-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1885: CLOUDSTACK-9724: Fixed missing additional pub...
Content-Type: text/plain
Message-Id: <20170214090132.123D8DFD73@git1-us-west.apache.org>
Date: Tue, 14 Feb 2017 09:01:32 +0000 (UTC)
archived-at: Tue, 14 Feb 2017 09:01:34 -0000

Github user jayapalu commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1885#discussion_r100985099
  
    --- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
    @@ -460,6 +460,12 @@ boolean checkIfIpAssocRequired(Network network, boolean postApplyRules, List<Pub
                         }
                     } else {
                         if (activeCount != null && activeCount > 0) {
    +                        if (network.getVpcId() != null) {
    --- End diff --
    
    Improved. Added more details


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---