cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nvazquez <...@git.apache.org>
Subject [GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Date Tue, 28 Feb 2017 19:07:04 GMT
Github user nvazquez commented on the issue:

    https://github.com/apache/cloudstack/pull/1935
  
    Hi @rafaelweingartner, I've refactored the code instead of using `rollBackState` as static.
I think that using static variable could lead to a problem if new methods are invoked from
another method different than `deleteDomain` method. Instead of declaring it as static, we
reduced the scope again and only set it true when `CloudRuntimeException` is thrown. What
do you think about this refactor? I tryied not to introduce major changes in original code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message