cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ustcweizhou <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1978: CLOUDSTACK-9779 : Releasing secondary guest I...
Date Tue, 28 Feb 2017 09:59:02 GMT
Github user ustcweizhou commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1978#discussion_r103416124
  
    --- Diff: server/test/resources/createNetworkOffering.xml ---
    @@ -34,22 +34,23 @@
                 <ref bean="transactionContextBuilder" />
                 <ref bean="actionEventInterceptor" />
             </list>
    -    </property>
    -  </bean>
    -
    -    <bean id="nicIpAliasDaoImpl" class="com.cloud.vm.dao.NicIpAliasDaoImpl" />
    -    <bean id="ConfigurationManager" class="com.cloud.configuration.ConfigurationManagerImpl">
    -        <property name="name" value="ConfigurationManager"/>
    -    </bean>
    -
    -    <bean class="org.apache.cloudstack.networkoffering.ChildTestConfiguration" />
    +    </property>
    +  </bean>
    +
    +    <bean id="nicIpAliasDaoImpl" class="com.cloud.vm.dao.NicIpAliasDaoImpl" />
    +    <bean id="ConfigurationManager" class="com.cloud.configuration.ConfigurationManagerImpl">
    +        <property name="name" value="ConfigurationManager"/>
    +    </bean>
    +
    +    <bean class="org.apache.cloudstack.networkoffering.ChildTestConfiguration" />
         <bean id="UservmDetailsDaoImpl" class="com.cloud.vm.dao.UserVmDetailsDaoImpl"
/>
         <bean id="hostGpuGroupsDaoImpl" class="com.cloud.gpu.dao.HostGpuGroupsDaoImpl"
/>
    -    <bean id="vGPUTypesDaoImpl" class="com.cloud.gpu.dao.VGPUTypesDaoImpl" />
    -    <bean id="usageEventDaoImpl" class="com.cloud.event.dao.UsageEventDaoImpl" />
    -    <bean id="usageEventDetailsDaoImpl" class="com.cloud.event.dao.UsageEventDetailsDaoImpl"
/>
    -    <bean id="storagePoolHostDaoImpl" class="com.cloud.storage.dao.StoragePoolHostDaoImpl"
/>
    +    <bean id="vGPUTypesDaoImpl" class="com.cloud.gpu.dao.VGPUTypesDaoImpl" />
    +    <bean id="usageEventDaoImpl" class="com.cloud.event.dao.UsageEventDaoImpl" />
    +    <bean id="usageEventDetailsDaoImpl" class="com.cloud.event.dao.UsageEventDetailsDaoImpl"
/>
    +    <bean id="storagePoolHostDaoImpl" class="com.cloud.storage.dao.StoragePoolHostDaoImpl"
/>
         <bean id="primaryDataStoreDaoImpl" class="org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDaoImpl"
/>
    +    <bean id="loadBalancerVMMapDaoImpl" class="com.cloud.network.dao.LoadBalancerVMMapDaoImpl"
/>
    --- End diff --
    
    this change LGTM, otherwise the unit tests will fail


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message