cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...
Date Tue, 28 Feb 2017 08:13:53 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1960#discussion_r103221221
  
    --- Diff: api/src/org/apache/cloudstack/api/command/admin/host/PrepareForMaintenanceCmd.java
---
    @@ -108,4 +108,8 @@ public void execute() {
                 throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed to prepare
host for maintenance");
             }
         }
    +
    +    public void setHostId(final Long hostId) {
    --- End diff --
    
    naming: consistency would dictate this be called setId()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message