cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack issue #1973: CLOUDSTACK-9795: moved logrotate from cron.daily to ...
Date Mon, 27 Feb 2017 21:59:35 GMT
Github user rafaelweingartner commented on the issue:

    https://github.com/apache/cloudstack/pull/1973
  
    @dmabry as I posted on the other PR, I only suggested `git cherry-pick` because I thought
it would preserve the commit hash. It was a misunderstanding from me. The git hash is generated
based on parent commit as well as other bits of information. Therefore, even when using `git
cherry-pick` the hash of commits between branches will always be different (unless a hash
collision happens). 
    
    The `git cherry-pick` is quite useful when you have to apply a bunch of changes, but in
your case, I do not think you need it. The way you did before was ok.
    
    BTW: I think a single commit to introduce these changes is enough ;)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message