cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From niteshsarda <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1972: CLOUDSTACK-9779 : Releasing secondary guest I...
Date Mon, 27 Feb 2017 11:55:13 GMT
Github user niteshsarda commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1972#discussion_r103190716
  
    --- Diff: engine/schema/src/com/cloud/network/dao/LoadBalancerDao.java ---
    @@ -29,4 +30,6 @@
     
         List<LoadBalancerVO> listInTransitionStateByNetworkIdAndScheme(long networkId,
Scheme scheme);
     
    +    boolean isLoadBalancerRulesMappedToVmGuestIp(long instanceId, String instanceIp,
long networkId, FirewallRule.Purpose purpose);
    --- End diff --
    
    @SudharmaJain : As per suggestion, removed Purpose parameter from method signature and
added directly in the SearchBuilder. 
    
    Please check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message