cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From SudharmaJain <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1972: CLOUDSTACK-9779 : Releasing secondary guest I...
Date Mon, 27 Feb 2017 09:00:23 GMT
Github user SudharmaJain commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1972#discussion_r103159426
  
    --- Diff: engine/schema/src/com/cloud/network/dao/LoadBalancerDao.java ---
    @@ -29,4 +30,6 @@
     
         List<LoadBalancerVO> listInTransitionStateByNetworkIdAndScheme(long networkId,
Scheme scheme);
     
    +    boolean isLoadBalancerRulesMappedToVmGuestIp(long instanceId, String instanceIp,
long networkId, FirewallRule.Purpose purpose);
    --- End diff --
    
    @niteshsarda You don't need the purpose parameter here, as the implementation is specific
for firewall rules. While setting the parameter with SearchBuilder the value can be set as
 Purpose.LoadBalancing. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message