cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ustcweizhou <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1972: CLOUDSTACK-9779 : Releasing secondary guest I...
Date Sat, 25 Feb 2017 06:17:13 GMT
Github user ustcweizhou commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1972#discussion_r103072546
  
    --- Diff: engine/schema/src/com/cloud/network/dao/LoadBalancerDaoImpl.java ---
    @@ -75,4 +84,40 @@ protected LoadBalancerDaoImpl() {
             return listBy(sc);
         }
     
    +    @Override
    +    public boolean isLoadBalancerRulesMappedToVmGuestIp(long instanceId, String instanceIp,
long networkId, FirewallRule.Purpose purpose)
    +    {
    +        SearchBuilder<LoadBalancerVMMapVO> lbVmMapSearch = _loadBalancerVMMapDao.createSearchBuilder();
    +        lbVmMapSearch.and("instanceIp", lbVmMapSearch.entity().getInstanceIp(),SearchCriteria.Op.EQ);
    +        lbVmMapSearch.and("instanceId", lbVmMapSearch.entity().getInstanceId(), SearchCriteria.Op.EQ);
    +
    +        SearchBuilder<FirewallRuleVO> firewallRuleIdSearch = _firewallRulesDao.createSearchBuilder();
    --- End diff --
    
    You might know LoadBalancerVO extends FirewallRuleVO, you can use LoadBalancerVO instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message