cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From serg38 <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1958: CLOUDSTACK-5806: add presetup to storage type...
Date Thu, 23 Feb 2017 16:26:58 GMT
Github user serg38 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1958#discussion_r102753237
  
    --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java ---
    @@ -508,7 +507,7 @@ public String updateConfiguration(final long userId, final String
name, final St
                         throw new InvalidParameterValueException("unable to find storage
pool by id " + resourceId);
                     }
                     if(name.equals(CapacityManager.StorageOverprovisioningFactor.key()))
{
    -                    if(pool.getPoolType() != StoragePoolType.NetworkFilesystem &&
pool.getPoolType() != StoragePoolType.VMFS) {
    +                    if(pool.getPoolType().supportsOverProvisioning() ) {
    --- End diff --
    
    I believe it should be negated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message