cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...
Date Thu, 23 Feb 2017 15:24:36 GMT
Github user rafaelweingartner commented on the issue:

    https://github.com/apache/cloudstack/pull/1957
  
    Actually, my concerns are not regarding the response. Reading the name of the method one
can for sure understand what it returns. My concern is that reading the parameter name `keyword`
I really have no clue that this keyword is part of a username. The `keyword` could be used
to list users of domains that may match it; the same can be applied for projects. Did you
understand what I mean?
    I was trying to discuss if we could find a better way to document it. As you also checked,
there are other methods that this situation happens. However, I really do not believe this
is a good standard to follow.
    Would not something like the following work as well?
    ```
    ...
    sb.and("id", sb.entity().getId(), SearchCriteria.Op.EQ);
    sb.and("state", sb.entity().getState(), Op.IN);
    sb.and().op("username", sb.entity().getUsername(), SearchCriteria.Op.EQ).or("username",
"%" + sb.entity().getUsername() + "%" , SearchCriteria.Op.LIKE);
    ...
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message