cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From koushik-das <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1941: CLOUDSTACK-8663: Fixed various issues to allo...
Date Thu, 23 Feb 2017 12:05:29 GMT
Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1941#discussion_r102698293
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
    @@ -1415,6 +1417,10 @@ public VM createWorkingVM(final Connection conn, final String vmName,
final Stri
                 vbdr.userdevice = "autodetect";
                 vbdr.mode = Types.VbdMode.RW;
                 vbdr.type = Types.VbdType.DISK;
    +            Long deviceId = volumeTO.getDeviceId();
    +            if (deviceId != null && (!isDeviceUsed(conn, vm, deviceId) || deviceId
> 3)) {
    --- End diff --
    
    I remember seeing these changes in another PR, check if that is merged or not


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message