cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wido <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for K...
Date Thu, 23 Feb 2017 10:52:36 GMT
Github user wido commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1955#discussion_r102687039
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
    @@ -2059,6 +2060,13 @@ So if getMinSpeed() returns null we fall back to getSpeed().
             final InputDef input = new InputDef("tablet", "usb");
             devices.addDevice(input);
     
    +        // If we're using virtio scsi, then we need to add a virtual scsi controller
    +        if (getGuestDiskModel(vmTO.getPlatformEmulator()) == DiskDef.DiskBus.SCSI) {
    +            final SCSIDef sd = new SCSIDef((short)0, 0, 0, 9, 0);
    +            devices.addDevice(sd);
    +            s_logger.debug("Adding scsi definition:\n" + sd.toString());
    --- End diff --
    
    Might want to include the name of the VM here as well? And SCSI is written in upper-case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message