cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshanaparti <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...
Date Thu, 23 Feb 2017 07:19:04 GMT
Github user sureshanaparti commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1813#discussion_r102651816
  
    --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
    @@ -3520,27 +3520,17 @@ public UserVmVO doInTransaction(TransactionStatus status) throws
InsufficientCap
                         }
                         rootDiskSize = Long.parseLong(customParameters.get("rootdisksize"));
     
    -                    // only KVM supports rootdisksize override
    -                    if (hypervisorType != HypervisorType.KVM) {
    -                        throw new InvalidParameterValueException("Hypervisor " + hypervisorType
+ " does not support rootdisksize override");
    +                    // only KVM, XenServer and VMware  supports rootdisksize override
    +                    if (!(hypervisorType == HypervisorType.KVM || hypervisorType == HypervisorType.XenServer
|| hypervisorType == HypervisorType.VMware)) {
    +                        throw new InvalidParameterValueException("Hypervisor " + hypervisorType
+ " does not support  rootdisksize override");
    --- End diff --
    
    The condition in VolumeApiServiceImpl.java at line# 1029 above and this doesn't match.
You skipped None and Any. Is that intentional?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message