cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From koushik-das <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...
Date Wed, 22 Feb 2017 11:58:08 GMT
Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1771#discussion_r102445777
  
    --- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
    @@ -3085,9 +3085,10 @@ public GuestVlan dedicateGuestVlanRange(DedicateGuestVlanRangeCmd
cmd) {
             // Verify account is valid
             Account vlanOwner = null;
             if (projectId != null) {
    -            if (accountName != null) {
    -                throw new InvalidParameterValueException("accountName and projectId are
mutually exclusive");
    -            }
    +            //accountName and projectId are mutually exclusive
    --- End diff --
    
    @nitin-maharana @ustcweizhou The scope field in UI should be fine. But since there is
a breaking change (accountName is made optional from required), there may be scenarios which
will break. As long as it is documented should be ok.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message