cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nvazquez <...@git.apache.org>
Subject [GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...
Date Wed, 22 Feb 2017 04:59:14 GMT
Github user nvazquez commented on the issue:

    https://github.com/apache/cloudstack/pull/1935
  
    @rafaelweingartner I think I got your point, I tried to keep code as similar as it was
before, by declaring `rollBackState` as static class variable on line 114. This way inner
`finally` block would work the same as before when one of new methods set `rollBackState =
true.` On outter `finally` block, `rollBackState` is set to false (line 345), this way each
time `deleteDomain` is invoked it would start on false (maybe it would be easier to move it
at the beggining of `deleteDomain`). Do you agree with this approach?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message