cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HrWiggles <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...
Date Tue, 21 Feb 2017 23:03:40 GMT
Github user HrWiggles commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1953#discussion_r102342529
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
    @@ -584,18 +584,36 @@ public void defFileBasedDisk(String filePath, String diskLabel,
DiskBus bus, Dis
     
             /* skip iso label */
             private String getDevLabel(int devId, DiskBus bus) {
    --- End diff --
    
    Would be great to have unit tests for either `getDevLabel(int devId, DiskBus bus)` or
`getDevLabelSuffix(int deviceIndex)`, especially to test for the expected results when `devId`
(or `deviceIndex`) are high enough to return a double-letter device label suffix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message