cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshanaparti <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...
Date Tue, 21 Feb 2017 20:01:06 GMT
Github user sureshanaparti commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1953#discussion_r102303229
  
    --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
    @@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm) {
             return maxDataVolumesSupported.intValue();
         }
     
    -    private Long getDeviceId(long vmId, Long deviceId) {
    +    private Long getDeviceId(UserVmVO vm, Long deviceId) {
             // allocate deviceId
    -        List<VolumeVO> vols = _volsDao.findByInstance(vmId);
    +        int maxDataVolumesSupported = getMaxDataVolumesSupported(vm);
    +        List<VolumeVO> vols = _volsDao.findByInstance(vm.getId());
             if (deviceId != null) {
    -            if (deviceId.longValue() > 15 || deviceId.longValue() == 3) {
    -                throw new RuntimeException("deviceId should be 1,2,4-15");
    +            if (deviceId.longValue() > maxDataVolumesSupported || deviceId.longValue()
== 3) {
    +                throw new RuntimeException("deviceId should be 1,2,4-" + maxDataVolumesSupported);
                 }
                 for (VolumeVO vol : vols) {
                     if (vol.getDeviceId().equals(deviceId)) {
    -                    throw new RuntimeException("deviceId " + deviceId + " is used by
vm" + vmId);
    +                    throw new RuntimeException("deviceId " + deviceId + " is used by
vm" + vm.getId());
                     }
                 }
             } else {
                 // allocate deviceId here
                 List<String> devIds = new ArrayList<String>();
    -            for (int i = 1; i < 15; i++) {
    +            for (int i = 1; i < maxDataVolumesSupported; i++) {
    --- End diff --
    
    @HrWiggles Thanks for pointing this. Addressed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message