cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatchi...
Date Tue, 21 Feb 2017 15:05:34 GMT
Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1878#discussion_r102226833
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
    @@ -2071,6 +2120,14 @@ protected StartAnswer execute(StartCommand cmd) {
             }
         }
     
    +    private void replaceNicsMacSequenceInBootArgs(String oldMacSequence, String newMacSequence,
VirtualMachineTO vmSpec) {
    +        String bootArgs = vmSpec.getBootArgs();
    +        if (!StringUtils.isEmpty(bootArgs) && !StringUtils.isEmpty(oldMacSequence)
&& !StringUtils.isEmpty(newMacSequence)) {
    +            //Update boot args with the new nic mac addresses
    --- End diff --
    
    What about moving this comment to the method documentation?
    Also, how do you feel about test cases? The method is pretty simple and it will not be
hard to write some unit test for it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message