cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remibergsma <...@git.apache.org>
Subject [GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...
Date Sun, 19 Feb 2017 20:48:30 GMT
Github user remibergsma commented on the issue:

    https://github.com/apache/cloudstack/pull/1953
  
    Thanks for the fix! 
    
    Although I think that after id=25 stuff breaks on KVM, as the code generates a deviceName
that is invalid. Id 25 results in vdz, after that it continues with caracters like `{` etc.
The default for KVM seems to be 32 (as defined here: https://github.com/apache/cloudstack/blob/87ef8137534fa798101f65c6691fcf71513ac978/setup/db/db/schema-452to460.sql#L422).
    
    See: https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java#L591
    
    So we either limit it to 25, or improve the code to generate valid device names above
id 25. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message