cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nitin-maharana <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...
Date Thu, 16 Feb 2017 09:00:46 GMT
Github user nitin-maharana commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1771#discussion_r101470562
  
    --- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
    @@ -3085,9 +3085,10 @@ public GuestVlan dedicateGuestVlanRange(DedicateGuestVlanRangeCmd
cmd) {
             // Verify account is valid
             Account vlanOwner = null;
             if (projectId != null) {
    -            if (accountName != null) {
    -                throw new InvalidParameterValueException("accountName and projectId are
mutually exclusive");
    -            }
    +            //accountName and projectId are mutually exclusive
    --- End diff --
    
    @koushik-das : As I mentioned in resolution part, Even if the account name is passed while
adding from a particular project view, then it is ignored(Removal part) in API. If we don't
remove that validation check, then the same issue will happen again. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message