cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swill <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1907: Fix public IPs not being removed from the VR ...
Date Mon, 13 Feb 2017 21:29:45 GMT
Github user swill commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1907#discussion_r100902927
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
    @@ -659,7 +663,10 @@ def is_guest_gateway(self, bag, ip):
             gw = interface.get_gateway()
             logging.info("Interface has the following gateway ==> %s", gw)
     
    -        if bag['nw_type'] == "guest" and rip == gw:
    +        guest_gw = self.config.cmdline().get_guest_gw()
    +        logging.info("Interface has the following gateway ==> %s", guest_gw)
    +
    +        if bag['nw_type'] == "guest" and (rip == gw or rip == guest_gw):
    --- End diff --
    
    I find that makes the code a bit harder to read if we did that. Then it is not as obvious
you are returning a boolean. This stuff is already complicated, for two lines of code, I don't
think it makes sense to make it harder to understand. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message