cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From koushik-das <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1885: CLOUDSTACK-9724: Fixed missing additional pub...
Date Mon, 13 Feb 2017 10:51:06 GMT
Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1885#discussion_r100767709
  
    --- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
    @@ -460,6 +460,12 @@ boolean checkIfIpAssocRequired(Network network, boolean postApplyRules,
List<Pub
                         }
                     } else {
                         if (activeCount != null && activeCount > 0) {
    +                        if (network.getVpcId() != null) {
    --- End diff --
    
    @jayapalu Please improve the code comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message