cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request #928: CLOUDSTACK-8950 Hypervisor Parameter check is ...
Date Mon, 13 Feb 2017 09:33:25 GMT
Github user karuturi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/928#discussion_r100753379
  
    --- Diff: server/src/com/cloud/template/TemplateAdapterBase.java ---
    @@ -293,9 +298,15 @@ public TemplateProfile prepare(GetUploadParamsForTemplateCmd cmd)
throws Resourc
                 zoneId = -1L;
             }
     
    +        HypervisorType hypervisorType = HypervisorType.getType(cmd.getHypervisor());
    +        if(hypervisorType == HypervisorType.None) {
    +            throw new InvalidParameterValueException("Hypervisor Type: " + cmd.getHypervisor()
+ " is invalid. Supported Hypervisor types are "
    +                                                         + EnumUtils.listValues(HypervisorType.values()).replace("None,
", ""));
    +        }
    --- End diff --
    
    @GabrielBrascher there is lot of duplicate code between the methods. A proper cleanup
has to be planned. Cant take up now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message