cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack issue #1938: CLOUDSTACK-9780: Fixed the default JAVA_HOME value t...
Date Fri, 10 Feb 2017 19:23:31 GMT
Github user rafaelweingartner commented on the issue:

    https://github.com/apache/cloudstack/pull/1938
  
    @Swill, I have a question (actually two) :)
    
    If “JAVA_HOME” is not set, or if “JAVA_HOME” content does not exist, we check
if there is a java installation. I have a doubt about this last path we are checking. Is this
path “/usr/lib/jvm/jre-1.8.0” default (some sort of standard)?
    
    I ask because (at least on Debian, or at least the Debian I am using) whenever I install
using “aptitude”, the java versions were added to folders following the pattern: “/usr/lib/jvm/java-<version>-openjdk-<processorArchiteture>/jre/”.
Of course, this is for OpenJDK installed with “aptitude”.
    
    Are we assuming that the user when installing manually (e.g. installing the JRE from Oracle)
will put Java JRE files in a folder like “/usr/lib/jvm/jre-1.8.0”?
    
    This will also only work for Java JRE 1.8.0, if users install Java JRE 1.8.1 and use the
version as the name of the folder, this would not work. Of course, all can be fixed by setting
the JAVA_HOME. 
    
    Would not it be better to cause an exception and stop the deployment with a message saying
that we require the “JAVA_HOME” to be set? Then, it feels that we will be consistent;
otherwise, I can imagine a user complaining that she/he has installed the Java 8 (1.8.x; where
x > 0), but still ACS does not work. 
    
    What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message