Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: serg38 <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1901-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1901-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1901: [4.9] CLOUDSTACK-9405: add details parameter ...
Content-Type: text/plain
Message-Id: <20170112162340.7DE7CDFA22@git1-us-west.apache.org>
Date: Thu, 12 Jan 2017 16:23:40 +0000 (UTC)
archived-at: Thu, 12 Jan 2017 16:23:42 -0000

Github user serg38 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1901#discussion_r95828294
  
    --- Diff: api/src/org/apache/cloudstack/api/command/admin/domain/ListDomainsCmd.java ---
    @@ -53,6 +59,12 @@
                    description = "If set to false, list only resources belonging to the command's caller; if set to true - list resources that the caller is authorized to see. Default value is false")
         private Boolean listAll;
     
    +    @Parameter(name = ApiConstants.DETAILS,
    +               type = CommandType.LIST,
    +               collectionType = CommandType.STRING,
    +               description = "comma separated list of host details requested, value can be a list of [ all, resource, min]")
    --- End diff --
    
    Can you clarify what would be permitted values for details parameter? If they are only "min", resource", "all" then we might want to change the name and description of this parameter to reflect true purpose. What is the difference between 'resource' and 'all'?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---