Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: koushik-das <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1727-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1727-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...
Content-Type: text/plain
Message-Id: <20170111061733.9031EDFC11@git1-us-west.apache.org>
Date: Wed, 11 Jan 2017 06:17:33 +0000 (UTC)
archived-at: Wed, 11 Jan 2017 06:17:36 -0000

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1727#discussion_r95516498
  
    --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
    @@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long vmSnapshotId) throws Insuffici
                 throw new InvalidParameterValueException("There is other active vm snapshot tasks on the instance, please try again later");
             }
     
    +        revertUserVmDetailsFromVmSnapshot(userVm, vmSnapshotVo);
    --- End diff --
    
    Are the details needed in the actual revert snapshot operation? If not then it is better to do these DB updates after the operation is completed successfully.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---