Return-Path: <dev-return-104038-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 5E726200BFF
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue,  3 Jan 2017 07:07:43 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 5D032160B30; Tue,  3 Jan 2017 06:07:43 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id CC81F160B22
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  3 Jan 2017 07:07:42 +0100 (CET)
Received: (qmail 37763 invoked by uid 500); 3 Jan 2017 06:07:41 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 37752 invoked by uid 99); 3 Jan 2017 06:07:41 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jan 2017 06:07:41 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 46EA5DFB32; Tue,  3 Jan 2017 06:07:41 +0000 (UTC)
From: anshul1886 <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1735-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1735-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1735: CLOUDSTACK-9570: Bug in listSnapshots for sna...
Content-Type: text/plain
Message-Id: <20170103060741.46EA5DFB32@git1-us-west.apache.org>
Date: Tue,  3 Jan 2017 06:07:41 +0000 (UTC)
archived-at: Tue, 03 Jan 2017 06:07:43 -0000

Github user anshul1886 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1735#discussion_r94362243
  
    --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotsCmd.java ---
    @@ -115,8 +115,10 @@ public void execute() {
             List<SnapshotResponse> snapshotResponses = new ArrayList<SnapshotResponse>();
             for (Snapshot snapshot : result.first()) {
                 SnapshotResponse snapshotResponse = _responseGenerator.createSnapshotResponse(snapshot);
    -            snapshotResponse.setObjectName("snapshot");
    -            snapshotResponses.add(snapshotResponse);
    +            if (snapshotResponse != null) {
    +                snapshotResponse.setObjectName("snapshot");
    --- End diff --
    
    Is any issue observed here for which null check is added?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---