cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashadeepa <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...
Date Mon, 30 Jan 2017 11:27:38 GMT
Github user Ashadeepa commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1910#discussion_r98422211
  
    --- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java ---
    @@ -596,7 +597,7 @@ public void doInTransactionWithoutResult(TransactionStatus status)
{
     
     
             sb.and("id", sb.entity().getId(), SearchCriteria.Op.EQ);
    -        sb.and("username", sb.entity().getUsername(), SearchCriteria.Op.EQ);
    +        sb.and("username", sb.entity().getUsername(), SearchCriteria.Op.LIKE);
    --- End diff --
    
    @ustcweizhou : Thanks but unfortunately, addOr & addAnd methods are now deprecated,
so I avoided using the same.
    
    Also, LIKE with work only when keyword is set. When only username is set,      `sc.setParameters("username",
username); `
    will get executed with the exact match i.e. same as how EQ will work!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message