cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashadeepa <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...
Date Mon, 30 Jan 2017 05:20:37 GMT
Github user Ashadeepa commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1910#discussion_r98381118
  
    --- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java ---
    @@ -613,6 +614,10 @@ public void doInTransactionWithoutResult(TransactionStatus status)
{
                 sc.setParameters("username", username);
             }
     
    +        if (keyword!= null) {
    +            sc.setParameters("username",  "%" + keyword + "%");
    +        }
    +
             Pair<List<VpnUserVO>, Integer> result = _vpnUsersDao.searchAndCount(sc,
searchFilter);
    --- End diff --
    
    @syed : If both are set, we are giving preference to keyword as the search will happen
using keyword query param. This is in according with other existing APIs. Keyword is the request
parameter for : List by keyword functionality. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message