cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From syed <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1913: CLOUDSTACK-9752: [Vmware] Optimization of vol...
Date Sun, 29 Jan 2017 22:42:06 GMT
Github user syed commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1913#discussion_r98365757
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
    @@ -1577,9 +1577,6 @@ public Answer createVolume(CreateObjectCommand cmd) {
                     }
     
                     synchronized (this) {
    -                    // s_logger.info("Delete file if exists in datastore to clear the
way for creating the volume. file: " + volumeDatastorePath);
    -                    VmwareStorageLayoutHelper.deleteVolumeVmdkFiles(dsMo, volumeUuid.toString(),
dcMo);
    -
                         vmMo.createDisk(volumeDatastorePath, (int)(volume.getSize() / (1024L
* 1024L)), morDatastore, vmMo.getScsiDeviceControllerKey());
                         vmMo.detachDisk(volumeDatastorePath, false);
    --- End diff --
    
    Is there a possibility that `detachDisk` might fail? In that case, we would require the
above check to be performed as Cloudstack would retry the operation. Same in the `finally`
clause


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message