cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mike-tutkowski <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1735: CLOUDSTACK-9570: Bug in listSnapshots for sna...
Date Wed, 11 Jan 2017 08:02:54 GMT
Github user mike-tutkowski commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1735#discussion_r94660806
  
    --- Diff: engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java
---
    @@ -56,7 +55,7 @@ public void config() {
     
         @Override
         public PrimaryDataStore getPrimaryDataStore(long dataStoreId) {
    -        StoragePoolVO dataStoreVO = dataStoreDao.findById(dataStoreId);
    +        StoragePoolVO dataStoreVO = dataStoreDao.findByIdIncludingRemoved(dataStoreId);
    --- End diff --
    
    Is getPrimaryDataStore(long) called from many places? If so, it might be a bit risky to
change this from findById to findByIdIncludingRemoved unless we are pretty sure all of the
calling code is OK with that change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message