cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...
Date Fri, 06 Jan 2017 22:57:27 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1883#discussion_r95035212
  
    --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java ---
    @@ -790,6 +791,18 @@ private String validateConfigurationValue(final String name, String
value, final
                 return null;
             }
     
    +        if (type.equals(Integer.class) && NetworkModel.MACIdentifier.key().equalsIgnoreCase(name))
{
    +            try {
    +                final int val = Integer.parseInt(value);
    +                if(val <0 || val >255){
    +                    throw new InvalidParameterValueException(name+" value should be between
0 and 255. 0 value will disable this feature");
    +                }
    --- End diff --
    
    Why are we using a magic value in the parameter to determine whether or not a feature
is enabled?  Why not add an explicit flag to make it clearer for the end user?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message