cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...
Date Fri, 06 Jan 2017 22:57:27 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1883#discussion_r95035461
  
    --- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
    @@ -83,9 +83,19 @@
         public final static int DEFAULT_AUTOSCALE_POLICY_INTERVAL_TIME = 30;
         public final static int DEFAULT_AUTOSCALE_POLICY_QUIET_TIME = 5 * 60;
         private final static Random s_rand = new Random(System.currentTimeMillis());
    -
    -    public static long createSequenceBasedMacAddress(final long macAddress) {
    -        return macAddress | 0x060000000000l | (long)s_rand.nextInt(32768) << 25
& 0x00fffe000000l;
    +    private final static long prefix = 0x1e;
    +
    +    public static long createSequenceBasedMacAddress(final long macAddress, long globalConfig)
{
    --- End diff --
    
    Is it acceptable for ``macAddress`` or ``globalConfig`` to be less than zero?  Is the
maximum value permitted?
    
    Also, please add unit test case(s) to verify the behavior of this method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message