cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1884: CLOUDSTACK-9699: Add global setting for enabl...
Date Fri, 06 Jan 2017 22:48:27 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1884#discussion_r95034635
  
    --- Diff: ui/scripts/ui/widgets/listView.js ---
    @@ -1922,7 +1922,14 @@
     
             // List view header actions
             if (listViewData.actions) {
    +            // If a preFilter is set, then get the values. Else set this to null
    +            var filteredActions = listViewData.actionPreFilter == undefined ?
    +                        null : listViewData.actionPreFilter();
                 $.each(listViewData.actions, function(actionName, action) {
    +                // filter out those actions that shouldn't be shown
    +                if (filteredActions != null
    +                        && (filteredActions.indexOf(actionName) < 0))
    +                    return false;
    --- End diff --
    
    Per coding standards, please surround all `if` blocks with curly braces.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message