cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From koushik-das <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP ...
Date Thu, 05 Jan 2017 07:07:06 GMT
Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1886#discussion_r94721965
  
    --- Diff: core/src/com/cloud/network/resource/TrafficSentinelResource.java ---
    @@ -228,6 +239,7 @@ private DirectNetworkUsageAnswer getPublicIpBytesSentAndReceived(DirectNetworkUs
                             answer.put(publicIp, bytesSentAndReceived);
                         }
                     }
    +                os.close();
    --- End diff --
    
    The input and output streams may not get closed in case of exception, it is better to
do any cleanup in the finally block.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message