cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anshul1886 <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1735: CLOUDSTACK-9570: Bug in listSnapshots for sna...
Date Wed, 04 Jan 2017 09:58:39 GMT
Github user anshul1886 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1735#discussion_r94555784
  
    --- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ---
    @@ -517,10 +517,10 @@ public String getSecondaryStorageURL(SnapshotVO snapshot) {
             List<Long> ids = getIdsListFromCmd(cmd.getId(), cmd.getIds());
     
             Ternary<Long, Boolean, ListProjectResourcesCriteria> domainIdRecursiveListProject
= new Ternary<Long, Boolean, ListProjectResourcesCriteria>(cmd.getDomainId(), cmd.isRecursive(),
null);
    -       _accountMgr.buildACLSearchParameters(caller, id, cmd.getAccountName(), cmd.getProjectId(),
permittedAccounts, domainIdRecursiveListProject, cmd.listAll(), false);
    -       Long domainId = domainIdRecursiveListProject.first();
    -       Boolean isRecursive = domainIdRecursiveListProject.second();
    -       ListProjectResourcesCriteria listProjectResourcesCriteria = domainIdRecursiveListProject.third();
    +        _accountMgr.buildACLSearchParameters(caller, id, cmd.getAccountName(), cmd.getProjectId(),
permittedAccounts, domainIdRecursiveListProject, cmd.listAll(), false);
    +        Long domainId = domainIdRecursiveListProject.first();
    +        Boolean isRecursive = domainIdRecursiveListProject.second();
    +        ListProjectResourcesCriteria listProjectResourcesCriteria = domainIdRecursiveListProject.third();
    --- End diff --
    
    These type of changes should not be done on unrelated file as it makes following changes
difficult.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message